[IPython-dev] windows readline vi mode

Jörgen Stenarson jorgen.stenarson at bostream.nu
Tue Mar 21 12:33:47 CST 2006


Hi again,

now I have commited yesterdays work on the vi-mode. I created a 
directory called test on the same level as modes,lineeditor, etc. lets 
keep all tests there until we feel the need for more structure. I have 
not added the tests you had in your patch.

/Jörgen

Jörgen Stenarson skrev:
> Hi Michael,
> 
> I'm about to commit some changes to the modes directory. Yesterday I did 
> some hacking to start integration of your vi patch. So far I can type 
> text, and some of the deletion commands works but there is a lot of work 
> left. As you suggest I have also started to move common things to a 
> separate file. I will commit this in an hour or so (I'll post to let you 
> know when it's done).
> 
> /Jörgen
> 
> Michael Graz skrev:
>> Hi Jörgen,
>> I looked at the refactoring branch a little.  The vi mode shares some code
>> with pyreadline\modes\emacs.py.  So it seems that file should be split up a
>> little bit.  One question: are things in a generally functional state?  If I
>> start change emacs.py into something like common.py, emacs.py and vi.py will
>> things be working enough for me to test?  Or are you still doing deep
>> refactoring.
>>
>> I also want to add a test_vi directory somewhere, perhaps as a subdirectory
>> of pyreadline\modes.  Let me know.
>> -Michael
>>
>> -----Original Message-----
>> From: Jörgen Stenarson [mailto:jorgen.stenarson at bostream.nu] 
>> Sent: Thursday, March 16, 2006 9:58 PM
>> To: Michael Graz; ipython-dev at scipy.net
>> Subject: Re: [IPython-dev] windows readline vi mode
>>
>> Michael Graz skrev:
>>> Okay, thanks for the info.  Here are my current changes:
>>> http://www.plan10.com/readline/readline-1.12a.zip 
>>>
>> Thanks for the link. It looks like your patch is a bit heavy to include 
>> in the trunk version. I'm also working on a refactored version where it 
>> will be easier to add new modes as plugins. I think we should 
>> concentrate on merging your work there. Perhaps you can have a look and 
>> see if you understand the code well enough to do the merge yourself.
>>
>> I'm happy to see you have added tests, something I have not worked on yet.
>>
>> You will probably see this but I have changed the indenting from 2 to 4 
>> spaces from UNC readline.
>>
>>
>> you can get it with svn:
>> "svn co 
>> http://ipython.scipy.org/svn/ipython/pyreadline/branches/refactor 
>> pyreadline-refactor"
>>
>> The layout is as below:
>>
>> pyreadline
>> 	rlmain      #contains Readline class
>> 	clipboard   #clipboard functions
>> 	console     #console interface
>> 	keysyms     #key symbol mappings
>> 	logger      #logging
>> 	release     #release info
>> 	
>> 	lineeditor
>> 		history     #implement history buffer
>> 		lineobj     #implement lineeditor interface (so
>>                              #movements etc doesn't have to be
>>                              #duplicated in all modes)
>> 		wordmatcher #functions for finding word boundaries
>>
>> 	modes             #editor modes
>> 		emacs     #emacs mode
>> 		notemacs  #crippled emacs for testing of mode
>> 			  #selection functionality
>>
>>
>> /Jörgen
>>
>>
> 
> _______________________________________________
> IPython-dev mailing list
> IPython-dev at scipy.net
> http://scipy.net/mailman/listinfo/ipython-dev
> 




More information about the IPython-dev mailing list