[IPython-dev] iplib fix (#1)

Fernando Perez fperez.net@gmail....
Sat Mar 10 03:27:55 CST 2007


Hi Dan,

On 3/2/07, Dan Milstein <danmil@comcast.net> wrote:
> Fernando (/Alex),
>
> Attached is a patch to the most recent version of iplib which fixes
> the problem reported.  Let's call it fix #1 because it doesn't
> represent the full overhaul of prefilter which is oh-so-close ;-).
>
> Also attached is a patch to test_prefilter.py so that it captures
> this problem (thanks to Alex's detailed report).
>
> The change is just in the first part of the line_split regex, from:
>
>      self.line_split = re.compile(r'^([\s*,;/])'
>
> To:
>
>      self.line_split = re.compile(r'^(\s*[,;/]?\s*)'
>
> The \s* doesn't work inside the [] (special chars are turned off, so
> that matches a '*' or a single whitespace), so the match was failing
> when it shouldn't, and falling back on whitespace splitting.  Now
> that first part can match whitespace optionally mixed with a single
> autocall esc char.
>
> This, um, fixed the problem, though I wouldn't swear as to *how* (see
> note about full rewrite above).

Thanks, I just committed both patches as of r2135.

Cheers,

f


More information about the IPython-dev mailing list