[IPython-dev] IPython.fronend progress

Gael Varoquaux gael.varoquaux@normalesup....
Mon Jun 23 12:11:40 CDT 2008


On Sun, Jun 15, 2008 at 04:03:31PM -0700, Barry Wark wrote:
> At this point, I would appreciate comments on the entire frontend
> package before we consider merging ipython-frontend into trunk.

OK, some first impression comments:

conding standards: 

    * Some lines are longer than 80 characters. I don't like this as I
      keep all my windows open at 80 characters width, and I don't like
      lines wrapping.

    * The function naming convention is not systematic (eg
      frontendbase.py, line 101, there is a method with a CamelCase name,
      but right under there is one with underscore-sperated names.
      CamelCase is reserved for classes. I don't care what twisted, apple
      modules or wx does, they go against pep 8.

On the code side of things, a lot of the methods in cocoa_frontend look
like they are not Cocoa-specific. They should be moved in the
frontendbase, IMHO.

More will probably come, but I wanted to post this right now, less I
never do it.

Just a stupid question: is their a good reason for not merging this
branch with trunk? It will probably get us more people running the code
or reviewing it, though I must admit that the fact that the only
available frontend is a cocoa one prevents me totally forom trying the
code out.

Gaël



More information about the IPython-dev mailing list