[IPython-dev] IPython.fronend progress

Barry Wark barrywark@gmail....
Mon Jun 23 14:40:08 CDT 2008


On Mon, Jun 23, 2008 at 10:11 AM, Gael Varoquaux
<gael.varoquaux@normalesup.org> wrote:
> On Sun, Jun 15, 2008 at 04:03:31PM -0700, Barry Wark wrote:
>> At this point, I would appreciate comments on the entire frontend
>> package before we consider merging ipython-frontend into trunk.
>
> OK, some first impression comments:
>
> conding standards:
>
>    * Some lines are longer than 80 characters. I don't like this as I
>      keep all my windows open at 80 characters width, and I don't like
>      lines wrapping.

Quite right. Sorry. That will definitely be fixed.

>
>    * The function naming convention is not systematic (eg
>      frontendbase.py, line 101, there is a method with a CamelCase name,
>      but right under there is one with underscore-sperated names.
>      CamelCase is reserved for classes. I don't care what twisted, apple
>      modules or wx does, they go against pep 8.

I thought I had cleaned up everything that didn't override Twisted or
Cocoa methods to be PEP 8 compliant. I will double check that again.

>
> On the code side of things, a lot of the methods in cocoa_frontend look
> like they are not Cocoa-specific. They should be moved in the
> frontendbase, IMHO.

Good point. I will have an other look at that separation. Some things
ended up in the cocoa-specific frontend because they are specific to
how the cocoa frontend renders its UI -- a notebook based frontend
would be very different. In fact, the cocoa frontend is more a test
fixture at this point. Ultimately I would like to move it towards a
notebook-like interface. I will see whether there's anything in there
that is generall applicable to ALL frontend UIs, but I suspect there
isn't.

>
> More will probably come, but I wanted to post this right now, less I
> never do it.
>
> Just a stupid question: is their a good reason for not merging this
> branch with trunk? It will probably get us more people running the code
> or reviewing it, though I must admit that the fact that the only
> available frontend is a cocoa one prevents me totally forom trying the
> code out.

My intention was to merge as soon as some other eyes had taken a look
at, and OK'd, the code. It sounds like resolving the issues you raise
here will get me to being ready to merge. I will announce on the list
as soon as the merge to trunk is complete.

Thanks for your comments!

Barry

>
> Gaël
>
>


More information about the IPython-dev mailing list