[IPython-dev] Fully working Win32 installer

Prabhu Ramachandran prabhu@aero.iitb.ac...
Thu Sep 4 23:09:35 CDT 2008


Brian Granger wrote:
> In launchpad, when you propose a branch for merging and request
> review, a new page gets created for that code review:
> 
> https://code.launchpad.net/~ellisonbg/ipython/trunk-dev/+merge/933
> 
> This page only lists the commits that have not been reviewed _and_
> merged.  This page is a click or two away from the page you asked
> about.

Yes, I saw that link too.

>> Or is there something I'm missing.  I'm trying to get an idea of the patch,
>> review, merge workflow you guys are using.  Do you use Guido's code review
>> tool?  Can you?
> 
> I don't think you can use Guido's tools yet with bzr+launchpad.  But,
> Launchpad's new code review system seems to do a lot of what we need -
> and with 0 setup.
> 
> The workflow that are are playing around with is this:
> 
> 1.  All devs do their work in branches*
> 2.  When they have a set of commits ready for review, they propose
> that the branch be merged.
> 3.  People use Launchpad to review
> 4.  When all is OK, the merge happens.

Thanks for the clarifications.

If someone rejected 1128 you'd make 1129 and they'd review that, and 
once that is OK a merge will be done by the person in charge of the 
mainline.  Nice.

> *Sometimes the branches are short lived feature branches that go away
> after the merge.  Other branches (like my trunk-dev branch above) is
> long lived.  It is where I do much of my ipython development.  These
> branches have a continual merge proposal.  The merge page shows the
> latest commits that are ready to go and people can review just the
> un-merged ones.
> 
> We have lots of fine tuning to figure out, but overall I am liking it.
>  Compared to cvs/svn, this is lightyears ahead.

Yes, it seems really nice.  Thanks.

cheers,
prabhu



More information about the IPython-dev mailing list