[IPython-dev] Status of pre-0.10 reviews and merges
Wed Apr 8 12:56:24 CDT 2009
On Thu, Apr 2, 2009 at 8:06 PM, Brian Granger <firstname.lastname@example.org> wrote:
>> I can't review the branch on launchpad since I am not a part of the group.
> Fernando, can we add Vishal to the team?
Sorry, I'd missed this. I'm more than happy to add Vishal, with the
caveat to request that you (Vishal) do not merge into trunk at all.
As we use LP more and more and we settle into a good pattern for
usage, it becomes clearer to me that we can be reasonably liberal with
team membership, simply because it makes code review and collaboration
easier. I also don't want anyone to feel 'second class' regarding the
project, after all that's the whole point of using a DVCS and the
But I do want to make sure that only those who are *very* familiar
with the workflow and the tools merge directly into trunk. If nothing
else, because it's unfortunately far too easy to make a small mistake
in how you did your merges and mess up the history, as it happened to
all of us when we first transitioned to LP.
So as long as new team members can assure us that you will only write
to things like code reviews and specific branches where certain
features may be worked on by others, letting the final pushes into
trunk itself to the long-term members of the team, that's not a
problem. If this ever becomes an issue we could address it by making
a separate '~ipython-trunk' team only for trunk merges, but I'd rather
just have an informal policy for this.
More information about the IPython-dev