[IPython-dev] Bug with __del__methods on exit
Sun Oct 10 17:30:35 CDT 2010
On 10 October 2010 21:27, Fernando Perez <email@example.com> wrote:
> I committed a fix that pulls both forms (with and without the 's') and
> added a unit test. Thanks for help with tracking this down.
That's great. I've tweaked it for py3k, and it all seems to be working.
I committed a slightly different form with a more explicit comment,
> and leaving the original code still commented out, I think your idea
> of having it handy for someone tracking a problem is a good one for a
> while. I'd rather save one of us time in a debug session than be a
> stickler about code purity :)
Sounds like a good plan.
In the future, while we will *try* to not re-introduce things that you
> need to clean up, we may do so accidentally (none of us is running
> 2to3 regularly yet). So I hope you'll be able to point us to any
> inadvertent slips in that direction when they happen, and we'll fix
> them quickly. From my review of your branch, I had the impression
> most things were pretty easy (like using iter* methods on dicts so the
> semantics are unambiguous for the 2to3 tool).
OK, that's great. At present, my strategy is to have one branch with the
results of running 2to3 on trunk, which I merge into the branch containing
my changes (now renamed to ipython-py3k).
Yes, I've really just gone for best practices 2.6 code, which mostly
converts neatly. Using iter* methods is tidier, but not essential; without
them, 2to3 just wraps the method call in a list(...) to get the equivalent
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the IPython-dev