[IPython-dev] Shutdown __del__ methods bug

Fernando Perez fperez.net@gmail....
Fri Oct 22 12:59:18 CDT 2010


On Fri, Oct 22, 2010 at 2:49 AM, Thomas Kluyver <takowl@gmail.com> wrote:
>
> A couple of other things strike me about it:
> - In the ipython network graph on github, it doesn't show up as a merge
> (there's no other branch leading into it). You have to scroll back a bit now
> to see it, but it's the first in a cluster of three commits on trunk just
> before the number 11 on the date line.
> - Other merges usually mention branches in the commit message. This one just
> mentions a file.
>
> Perhaps Min can shed more light, if he remembers how he made the commit. It
> does seem that something didn't go to plan. I've noticed a few places where
> it's reverting to older forms of code (e.g. using exceptions.Exception), and
> I've been tidying them up in my cleanup-old-code branch. I'll put in a pull
> request.
>
> If you're worried about possible regressions, I think the best thing is for
> you and Min to go over the diff for that commit and work out which changes
> were intentional.

Yes, I am worried.  Min, let's try to get together sometime next week
and do a little forensics on this one, to make sure nothing else
slipped by.  I'd also like to understand *what happened* so we don't
repeat this in the future, but I admit I'm puzzled right now.

Cheers,

f


More information about the IPython-dev mailing list