[IPython-dev] Code review (mostly for Fernando)

Fernando Perez fperez.net@gmail....
Sat Sep 18 13:18:55 CDT 2010


On Sat, Sep 18, 2010 at 9:10 AM, Brian Granger <ellisonbg@gmail.com> wrote:
>
> I just looked through everything and it looks great. Thanks for doing
> this.  Things are looking really good.

Great, thanks for the careful eyes!  Review is time and
energy-consuming, I really appreciate your thoroughness.  It's made
our codebase that much better.

I also noticed the github pull requests got much, much better:

http://github.com/blog/712-pull-requests-2-0

they pretty much fixed all the things that bothered me about their
prior system.  As we slow down the frenzy in newkernel, it will be
very nice to be able to use a stable, archived and featureful pull
request system for review.

Regards,

f


More information about the IPython-dev mailing list