[IPython-dev] Code review (mostly for Fernando)

Brian Granger ellisonbg@gmail....
Sat Sep 18 13:22:37 CDT 2010


On Sat, Sep 18, 2010 at 11:18 AM, Fernando Perez <fperez.net@gmail.com> wrote:
> On Sat, Sep 18, 2010 at 9:10 AM, Brian Granger <ellisonbg@gmail.com> wrote:
>>
>> I just looked through everything and it looks great. Thanks for doing
>> this.  Things are looking really good.
>
> Great, thanks for the careful eyes!  Review is time and
> energy-consuming, I really appreciate your thoroughness.  It's made
> our codebase that much better.
>
> I also noticed the github pull requests got much, much better:
>
> http://github.com/blog/712-pull-requests-2-0
>
> they pretty much fixed all the things that bothered me about their
> prior system.  As we slow down the frenzy in newkernel, it will be
> very nice to be able to use a stable, archived and featureful pull
> request system for review.

Yes i saw that and Min and I have been using it for the pyzmq code
review.  It is pretty great.  My only complaint is that for files with
many diffs they don't show the diffs in the web page.  You have the
download the two files and do the diff by hand.  But it is vastly
better than anything else right now.

Cheers,

Brian

> Regards,
>
> f
>



-- 
Brian E. Granger, Ph.D.
Assistant Professor of Physics
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu
ellisonbg@gmail.com


More information about the IPython-dev mailing list