[IPython-dev] Helping battle testing the newapp branch

MinRK benjaminrk@gmail....
Mon Jun 20 22:38:21 CDT 2011


On Mon, Jun 20, 2011 at 20:09, Fernando Perez <fperez.net@gmail.com> wrote:
> On Mon, Jun 20, 2011 at 4:38 PM, MinRK <benjaminrk@gmail.com> wrote:
>> Is that a 'go' for merge? If so, I'll tag&merge once I get home in an
>> hour or so.  Or we can wait a day or so for objections.
>>
>
> From my side, it's a go.  The ideas are sound, and we're at the point
> where what we need is battle testing to shake out the problems.  So I
> don't see holding on having much value at this point.

Okay, I will go ahead with the merge this evening, then.

Since this is merging newapp, I'll call the pre-merge tag 'oldapp'.

>
> Some minor comments:
>
> - This variable seems to be ignored now, it worked in master:
>
> c.Global.ignore_old_config = True

Nothing looks at the Global config anymore. This is now
application-level, in c.InteractiveShellApp.ignore_old_config I
believe (I don't see these warnings with my default config).  Perhaps
it should be moved to BaseIPythonApplication, though.

>
> for people who have a single ipython_dir (like me) because they need
> to handle both 0.10 and 0.11 series simultaneously, it's nice to have
> a way to silence all those warnings.
>
> - I don't think we should print the profile name in the default case,
> it's just noise.  I realize we now have a more consistent structure
> for profiles and even the default case is now a profile, but we should
> keep the amount of printed stuff to a minimum in the default cases.

Easy enough, I'll do this before merging.

-MinRK

>
> Otherwise, it looks good, passes the test suite, etc.
>
> Cheers,
>
> f
>


More information about the IPython-dev mailing list