[IPython-dev] Heads-up (esp. Thomas) - eyes needed on 74c10b3c

Fernando Perez fperez.net@gmail....
Sat Apr 14 04:17:46 CDT 2012


Howdy,

after an insane 5 weeks (lots of good news for IPython, I'll try to
post a summary soon), I'm trying to catch up on the backlog, and
yesterday merged several PRs.  In particular,
https://github.com/ipython/ipython/pull/1538, which unfortunately I
failed to notice broke the py3 builds.

Fortunately thanks to Thomas' setup of shining panda, I got a warning
very quickly (it will be great when we can trigger these builds *pre*
merging with something like the sympy bot/github integration).  So
I've just pushed a quick emergency commit which (I did test) fixes
installation and the full test suite on python3:

https://github.com/ipython/ipython/commit/74c10b3c03e377612b54eac8eb19fe0c95930683

but I'd like in particular Thomas to have a look in case there's
anything specific to our py3 machinery I should/could have done
differently.  I think it's OK, but since I don't use py3 regularly, a
bit of review would be good (and  in any case, for these kinds of
unreviewed emergency commits, post-hoc review is always a good
practice).

Cheers,

f


More information about the IPython-dev mailing list