[IPython-dev] Style Rules for Notebook

Thomas Kluyver takowl@gmail....
Wed Aug 22 12:09:16 CDT 2012


On 22 August 2012 17:42, Matthias BUSSONNIER
<bussonniermatthias@gmail.com> wrote:
> Don't hesitate to open a PR even before finishing the code

Just to expand on this: if you're making a PR for discussion, and you
know the code isn't finished, you can start the description with a
note like "not ready for merge".

If you've done everything you want to do with the code, no disclaimer
is necessary, but even so, don't be surprised if we ask you to make a
few changes. Almost every PR (apart from typo fixing) gets some
changes before it's merged. Code review is really important, even for
core developers.

Best wishes,
Thomas


More information about the IPython-dev mailing list