[IPython-dev] pull requests

Matthias BUSSONNIER bussonniermatthias@gmail....
Thu Sep 19 05:04:47 CDT 2013


Le 19 sept. 2013 à 11:49, Cyrille Rossant a écrit :

> I have a quick and possibly dumb question: should Pull Requests be
> made against master or in a new branch?
> 
> Yes according to
> https://github.com/ipython/ipython/wiki/Dev:-GitHub-workflow#pull-requests
> 
> No according to
> http://ipython.org/ipython-doc/dev/development/gitwash/development_workflow.html#workflow-summary

I'm not sure I see where this state that PR should not be done gains master. 
Anyway. 

Usually you will push a named branched on your repo. and you ask to merge this branch into ipython/master
So github will send a mail 

Cyrille want to merge crossant/my-awesome-feature into ipython/master


> 
> Could you please clarify?

Does this help ?

-- 
M


More information about the IPython-dev mailing list