[Numpy-discussion] numpy distutils patch

[Jarrod Millman]

Hello,

I never got any reply about the 'fix' for distutils.util.split_quoted
in numpy/distutils/ccompiler.py.  Can anyone confirm whether this fix
is correct or necessary?  If so, I would like to submit a patch
upstream for this.

Thanks,

On Oct 29, 2007 2:17 AM, Jarrod Millman <millman@berkeley.edu> wrote:
> Hey,
>
> I was looking at numpy/distutils/ccompiler.py and noticed that it has
> a fix for distutils.util.split_quoted.
>
> Here is the relevant code from split_quoted in numpy.distutils.ccompiler:
> -----------------------------------
> def split_quoted(s):
>
> <snip>
>
>            if _has_white_re.search(s[beg+1:end-1]):
>                 s = s[:beg] + s[beg+1:end-1] + s[end:]
>                 pos = m.end() - 2
>             else:
>                 # Keeping quotes when a quoted word does not contain
>                 # white-space. XXX: send a patch to distutils
>                 pos = m.end()
>
> <snip>
> -----------------------------------
>
> Here is the relevant code from split_quoted in distutils.util:
> -----------------------------------
> def split_quoted(s):
>
> <snip>
>
>             s = s[:beg] + s[beg+1:end-1] + s[end:]
>             pos = m.end() - 2
>
> <snip>
> -----------------------------------
>
> Does anyone know if a patch was ever submitted upstream?  If not, is
> there any reason that a patch shouldn't be submitted?
>
> Thanks,
>
> --
> Jarrod Millman
> Computational Infrastructure for Research Labs
> 10 Giannini Hall, UC Berkeley
> phone: 510.643.4014
> http://cirl.berkeley.edu/
>



-- 
Jarrod Millman
Computational Infrastructure for Research Labs
10 Giannini Hall, UC Berkeley
phone: 510.643.4014
http://cirl.berkeley.edu/