[Numpy-discussion] let's use patch review

Ondrej Certik ondrej@certik...
Thu May 15 10:32:37 CDT 2008


On Thu, May 15, 2008 at 3:08 PM, David Huard <david.huard@gmail.com> wrote:
> 2008/5/14 David Cournapeau <cournapeau@cslab.kecl.ntt.co.jp>:
>>
>> On Wed, 2008-05-14 at 13:58 -1000, Eric Firing wrote:
>> >
>> > What does that mean?  How does one know when there is a consensus?
>>
>> There can be a system to make this automatic. For example, the code is
>> never commited directly to svn, but to a gatekeeper, and people vote by
>> an email command to say if they want the patch in; when the total number
>> of votes is above some threshold, the gatekeeper commit the patch.
>
> There is about 5 commits/day, I don't think it's a good idea to wait for a
> vote on each one of them.

Me neither. I think just one reviewer is enough.

Ondrej


More information about the Numpy-discussion mailing list