[Numpy-discussion] Fix to #789 maybe not right.

David Cournapeau david@ar.media.kyoto-u.ac...
Wed May 21 22:03:20 CDT 2008


Charles R Harris wrote:
>
>
> And I'm not sure self->desc needs its reference count decremented, 
> PyArray_FromArray is one of those vicious, nasty functions with side 
> effects and might decrement the count itself.

might ? What do you mean by might decrement ? If the call to 
PyAarray_FromArray fails, no reference are stolen, right ?

> Note that the reference count is not decremented elsewhere. It's a 
> capital offense to write such functions, but there it is.
>
> On a lesser note, there is trailing whitespace on every new line 
> except one.

This is easier to fix :)

cheers,

David


More information about the Numpy-discussion mailing list