[Numpy-discussion] More loadtxt() changes

Ryan May rmay31@gmail....
Tue Nov 25 23:23:22 CST 2008


Pierre GM wrote:
> On Nov 25, 2008, at 10:02 PM, Ryan May wrote:
>> Pierre GM wrote:
>>> * Your locked version of update won't probably work either, as you  
>>> force
>>> the converter to output a string (you set the status to largest
>>> possible, that's the one that outputs strings). Why don't you set the
>>> status to the current one (make a tmp one if needed).
>> Looking at the code, it looks like mapper is only used in the  
>> upgrade()
>> method. My goal by setting status to the largest possible is to lock  
>> the
>> converter to the supplied function.  That way for the user supplied
>> converters, the StringConverter doesn't try to upgrade away from  
>> it.  My
>> thinking was that if the user supplied converter function fails, the
>> user should know. (Though I got this wrong the first time.)

Updated patch attached.  This includes:
  * Updated docstring
  * New tests
  * Fixes for previous issues
  * Fixes to make new tests actually work

I appreciate any and all feedback.

Ryan

-- 
Ryan May
Graduate Research Assistant
School of Meteorology
University of Oklahoma
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: loadtxt_changes.diff
Url: http://projects.scipy.org/pipermail/numpy-discussion/attachments/20081125/40b2ce53/attachment.pl 


More information about the Numpy-discussion mailing list