[Numpy-discussion] c++ comments in parse_datetime.c

Skipper Seabold jsseabold@gmail....
Tue Aug 25 13:03:51 CDT 2009


On Tue, Aug 25, 2009 at 1:59 PM, Skipper Seabold<jsseabold@gmail.com> wrote:
> On Tue, Aug 25, 2009 at 1:51 PM, Charles R
> Harris<charlesr.harris@gmail.com> wrote:
>> Hi Travis,
>>
>> The new parse_datetime.c file contains a lot of c++ style comments that
>> should be fixed. Also, the new test for mirr is failing on all the
>> buildbots.
>>
>> Chuck
>>
>
> Hi,
>
> For mirr it looks like the lines in the patch
> <http://projects.scipy.org/numpy/ticket/1138>
>
> pos = values * (values>0)
> neg = values * (values<0)
>
> were copied to the trunk as
>
> pos = values > 0
> neg = values < 0
>
> This is probably my fault for not submitting the patch as a diff.
>

Oops nevermind I didn't see that npv is now provided pos*values and neg*values.

Skipper


More information about the NumPy-Discussion mailing list