[Numpy-discussion] c++ comments in parse_datetime.c

Charles R Harris charlesr.harris@gmail....
Tue Aug 25 13:38:27 CDT 2009


On Tue, Aug 25, 2009 at 11:51 AM, Charles R Harris <
charlesr.harris@gmail.com> wrote:

> Hi Travis,
>
> The new parse_datetime.c file contains a lot of c++ style comments that
> should be fixed. Also, the new test for mirr is failing on all the
> buildbots.
>

Also,

1) There are two macros with gotos, which is a no-no. You could use inline
functions instead or just write out the code where needed.

2) Multiline comments like so:
/*
 * blah, blah
 */

3) Think twice about using trailing comments.

4) The constant defines should be collected in one spot and documented.

5) Use blank lines between all function definitions.

6) Use {} around all if statement blocks

7) Format else like so:
}
else if (bug) {
    blah;
}

8) The file contains hard tabs and trailing whitespace.

9) A number of lines are longer than 80 characters.

Yours Truly,
The Pedant ;)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/numpy-discussion/attachments/20090825/c5f1c170/attachment.html 


More information about the NumPy-Discussion mailing list