[Numpy-discussion] Applying Patch #1085
Sat Dec 5 01:12:44 CST 2009
On Dec 4, 2009, at 10:09 AM, Charles R Harris wrote:
> On Fri, Dec 4, 2009 at 6:29 AM, Travis Oliphant <firstname.lastname@example.org
> > wrote:
> What do people think of applying patch #1085. This patch makes a
> copy of inputs when the input and output views overlap in ways in
> which one computation will change later computations.
> I'd rename the function views_share_base_data, make the loop to find
> the base an inplace function, and break the long lines in the test.
> It looks like the routine doesn't try to determine if the views
> actually overlap, just if they might potentially share data. Is that
> correct? That seems safe and if the time isn't much it might be a
> nice safety catch. But it shouldn't go into 1.4.
It sounds like with a little clean-up that it can be applied to the
trunk. I agree that it shouldn't go into 1.4.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the NumPy-Discussion