[Numpy-discussion] Warnings in current trunk

Charles R Harris charlesr.harris@gmail....
Wed Feb 18 10:45:57 CST 2009


On Tue, Feb 17, 2009 at 11:37 PM, David Cournapeau <
david@ar.media.kyoto-u.ac.jp> wrote:

> Charles R Harris wrote:
> >
> > Oh, and this should be avoided:
> >
> >         if (endptr != NULL) *endptr = (char*)p;
> >
> > Folks have different views about whether the single statement should
> > be in brackets but no one recommends putting it on the same line as
> > the if. It's too easy to overlook and habit draws the eye to the
> > following line.
>
> That's not my code, so I did not want to change those, but I agree with
> you here (I prefer explicit brackets personally, but that's not mandated
> in the python code-style IIRC). There are a lot of those in numpy code,
> so if one want to change them, one should change them for good.
>

Yep. I'm trying to fix all of them this week which is why I complained.
Think of mopping the floor and the kid walks in with muddy shoes...

Chuck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://projects.scipy.org/pipermail/numpy-discussion/attachments/20090218/95bf40df/attachment.html 


More information about the Numpy-discussion mailing list