[Numpy-discussion] Datetime branch

Charles R Harris charlesr.harris@gmail....
Wed Jun 10 23:18:39 CDT 2009


Hi Travis,

I looked through the recent commits to the datetime branch and, as I'm
working on cleaning up arraytypes I would appreciate it if you can merge up
your changes there as soon as possible to minimize conflicts. Also, this
change looks like a reversion of current trunk to something older:

@@ -2688,10 +2690,8 @@
         goto err;
     }
-    /*
-     * PyExc_Exception should catch all the standard errors that are
-     * now raised instead of the string exception "multiarray.error".
-     * This is for backward compatibility with existing code.
-     */
-    PyDict_SetItemString (d, "error", PyExc_Exception);
+    /* Fixme: we might want to remove this old string exception string */
+    s = PyString_FromString("multiarray.error");
+    PyDict_SetItemString (d, "error", s);
+    Py_DECREF(s);
     s = PyString_FromString("3.0");
     PyDict_SetItemString(d, "__version__", s);

And I am concerned that there might be other such cases.

Chuck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/numpy-discussion/attachments/20090610/a07b0bbf/attachment.html 


More information about the Numpy-discussion mailing list