[Numpy-discussion] Enhancements for NumPy's FFTs

David Cournapeau cournape@gmail....
Tue Mar 17 04:07:25 CDT 2009


On Mon, Mar 16, 2009 at 2:43 AM, Sturla Molden <sturla@molden.no> wrote:
>
>> Well, that's nearly as good. (Though submitting a single svn diff
>> containing all changes could have been a bit more easy to handle than
>> separate patches for each file. But a small nitpick only.)
>
> The problem is I am really bad at using these tools. I have TortoiseSVN
> installed, but no idea how to use it. :(

You can use the command line version: svn diff gives exactly what you need.

Another thing is to separate different issues in different patches -
Treal -> double is different than npy_intp for indexing which is
different from the threading issue. It really makes life easier when
reviewing code.

I have a git branch with those changes, but I don't think I will
include it for 1.3. I don't have the time to make sure the fftpack
code really is thread-safe, and I don't want to merge the code without
at least one person to review it.

cheers,

David


More information about the Numpy-discussion mailing list