[Numpy-discussion] object array alignment issues
Mon Oct 19 16:55:17 CDT 2009
On Oct 19, 2009, at 9:55 AM, Michael Droettboom wrote:
> I've filed a bug and attached a patch:
> No guarantees that I've found all of the alignment issues. I did a
> for "PyObject **" to find possible locations where PyObject * in
> were being dereferenced. If I could write a unit test to make it fall
> over on Solaris, then I fixed it, otherwise I left it alone. For
> example, there are places where misaligned dereferencing is
> theoretically possible (OBJECT_dot, OBJECT_compare), but a higher
> function already did a "BEHAVED" array cast. In those cases I added a
> unit test so hopefully we'll be able to catch it in the future if the
> caller no longer ensures well-behavedness.
This patch looks great technically. Thank you for tracking this down
and correcting my error.
Right now, though, the patch has too many white-space only changes in
it. Could you submit a new patch that removes those changes?
More information about the NumPy-Discussion