[Numpy-discussion] object array alignment issues
Charles R Harris
Mon Oct 19 17:28:16 CDT 2009
On Mon, Oct 19, 2009 at 3:55 PM, Travis Oliphant <firstname.lastname@example.org>wrote:
> On Oct 19, 2009, at 9:55 AM, Michael Droettboom wrote:
> > I've filed a bug and attached a patch:
> > http://projects.scipy.org/numpy/ticket/1267
> > No guarantees that I've found all of the alignment issues. I did a
> > grep
> > for "PyObject **" to find possible locations where PyObject * in
> > arrays
> > were being dereferenced. If I could write a unit test to make it fall
> > over on Solaris, then I fixed it, otherwise I left it alone. For
> > example, there are places where misaligned dereferencing is
> > theoretically possible (OBJECT_dot, OBJECT_compare), but a higher
> > level
> > function already did a "BEHAVED" array cast. In those cases I added a
> > unit test so hopefully we'll be able to catch it in the future if the
> > caller no longer ensures well-behavedness.
> This patch looks great technically. Thank you for tracking this down
> and correcting my error.
> Right now, though, the patch has too many white-space only changes in
> it. Could you submit a new patch that removes those changes?
The old whitespace is hard tabs and needs to be replaced anyway. The new
whitespace doesn't always get the indentation right, however. That file
needs a style/whitespace cleanup.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the NumPy-Discussion