[Numpy-discussion] patch for structured array comparison bug

Charles R Harris charlesr.harris@gmail....
Tue Oct 19 02:09:54 CDT 2010


On Mon, Oct 18, 2010 at 7:13 PM, Mark Wiebe <mwwiebe@gmail.com> wrote:

> I found a bug in structured array comparison when fields have
> multi-dimensional types.  I created a ticket here:
>
> http://projects.scipy.org/numpy/ticket/1640
>
> and a patch here:
>
> http://github.com/m-paradox/numpy/compare/master...fix_structured_compare
>
> Could someone review it for me?
>
>
Just a quick look. I wasn't able to add comments to the code, maybe a pull
request would allow that or maybe you need to enable something. Also, it is
best to work in a branch, see the new
notes<%20%20%20%20http://docs.scipy.org/doc/numpy/dev/gitwash/development_workflow.html>on
the GIT workflow. I'm not sure how broadcasting is supposed to work
for
structured arrays so I will leave that to someone else. ISTR that the SUN
compiler is persnickety about the initialization of structures, only accepts
constants or some such. I'll try to track that down or maybe someone here
who is familiar with that compiler can comment.

Thanks for the work.

Chuck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/numpy-discussion/attachments/20101019/01dc5253/attachment.html 


More information about the NumPy-Discussion mailing list