[Numpy-discussion] Github migration?

Jason McCampbell jmccampbell@enthought....
Thu Sep 2 09:51:14 CDT 2010


On Wed, Sep 1, 2010 at 9:07 PM, Charles R Harris
<charlesr.harris@gmail.com>wrote:

>
> Hi Jason,
>
> On Tue, Aug 31, 2010 at 2:56 PM, Jason McCampbell <
> jmccampbell@enthought.com> wrote:
>
>> Hi Chuck (and anyone else interested),
>>
>> I updated the refactoring page on the NumPy developer wiki (seems to be
>> down or I'd paste in the link).  It certainly isn't complete, but there are
>> a lot more details about the data structures and memory handling and an
>> outline of some additional topics that needs to be filled in.
>>
>>
> I note that there are some C++ style comments in the code which will cause
> errors on some platforms, so I hope you are planning on removing them at
> some point. Also,
>

Mostly the C++ comments are there for specific things we need to fix before
it's complete (easier to search for).  Likely a few are attributable to
"muscle memory" in my fingers as well, but all will be removed as we button
it up.


>
> if (yes) foo;
>
> is very bad style. There is a lot of that in old code like that that still
> needs to be cleaned up, but I also see some in the new code. It would be
> best to get it right to start with.
>

Agreed.  In the code I have edited I typically re-write it as "if (NULL !=
yes) foo;" but a lot of code has been copied in wholesale and we haven't
always updated that code.


> <snip>
>
> Chuck
>
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion@scipy.org
> http://mail.scipy.org/mailman/listinfo/numpy-discussion
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/numpy-discussion/attachments/20100902/c6ddaa06/attachment.html 


More information about the NumPy-Discussion mailing list