[Numpy-discussion] Current datetime pull requests ready for review
Wed Jun 8 17:09:12 CDT 2011
On Wednesday, June 8, 2011, Mark Wiebe <firstname.lastname@example.org> wrote:
> I've been trying to separate out the features I've been doing into separate branches so I can split up into multiple pull, but the development I'm doing works pretty poorly with this workflow. Nearly every step of development builds on or uses changes from previous features. Since github doesn't do dependent pull requests, I'm going to go back to developing in a single branch to merge into master periodically.
> There are currently two pull requests ready to go, which could use some review:
> "Datetime unit from string" https://github.com/numpy/numpy/pull/85
> This makes conversion from a string to a datetime scalar automatically detect the unit if it's not specified. To support the same idea for arrays will require adding generic time units as I described in another email.
> "Unify datetime/timedelta type promotion" https://github.com/numpy/numpy/pull/86
> This simplifies the rules of how datetimes and timedeltas combine to always take the gcd/more precise unit instead of having the various special cases as the NEP described. The motivation for this change was based on how restricting those rules felt after spending some time experimenting with datetime calculations.
> Please review!
Just a thought. I think one way to do something like dependent pull
requests is to develop each feature in it's own branch, and then have
a branch that would merge some of those feature branches. These
branches would represent the logical dependencies needed, and could be
It wouldn't quite be exactly what you are wanting, but maybe
something similar could be done with pull requests, since one can
continue developing in a branch until the pull is done.
Just thinking out loud...
More information about the NumPy-Discussion