[Numpy-discussion] code review for datetime arange

Ralf Gommers ralf.gommers@googlemail....
Thu Jun 9 16:27:19 CDT 2011


On Thu, Jun 9, 2011 at 10:58 PM, Mark Wiebe <mwwiebe@gmail.com> wrote:

> On Thu, Jun 9, 2011 at 3:41 PM, Christopher Barker <Chris.Barker@noaa.gov>
>  wrote:
>
> Your branch works fine for me (OS X, py2.6), no failures. Only a few
deprecation warnings like:
/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/unittest.py:336:
DeprecationWarning: DType strings 'O4' and 'O8' are deprecated because they
are platform specific. Use 'O' instead
  callableObj(*args, **kwargs)



>  Mark Wiebe wrote:
>> > Because of the nature of datetime and timedelta, arange has to be
>> > slightly different than with all the other types. In particular, for
>> > datetime the primary signature is np.arange(datetime, datetime,
>> timedelta).
>> >
>> > I've implemented a simple extension which allows for another way to
>> > specify a date range, as np.arange(datetime, timedelta, timedelta).
>>
>> Did you think about how to document which of these basic functions work
with datetime? I don't think that belongs in the docstrings, but it may then
be hard for the user to figure out which functions accept datetimes. And
there will be no usage examples in the docstrings.

Besides docs, I am not sure about your choice to modify functions like
arange instead of writing a module of wrapper functions for them that know
what to do with the dtype. If you have a module you can group all relevant
functions, so they're easy to find. Plus it's more future-proof - if at some
point numpy grows another new dtype, just create a new module with wrapper
funcs for that dtype.

Cheers,
Ralf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/numpy-discussion/attachments/20110609/248c976c/attachment.html 


More information about the NumPy-Discussion mailing list