[Numpy-discussion] Pull request: Split maskna support out of mainline into a branch
Thu Jun 14 11:20:19 CDT 2012
On Thu, Jun 14, 2012 at 5:17 PM, Nathaniel Smith <email@example.com> wrote:
> On Wed, Jun 6, 2012 at 11:08 PM, Nathaniel Smith <firstname.lastname@example.org> wrote:
> > Just submitted this pull request for discussion:
> > https://github.com/numpy/numpy/pull/297
> > As per earlier discussion on the list, this PR attempts to remove
> > exactly and only the maskna-related code from numpy mainline:
> > http://mail.scipy.org/pipermail/numpy-discussion/2012-May/062417.html
> > The suggestion is that we merge this to master for the 1.7 release,
> > and immediately "git revert" it on a branch so that it can be modified
> > further without blocking the release.
> > The first patch does the actual maskna removal; the second and third
> > rearrange things so that PyArray_ReduceWrapper does not end up in the
> > public API, for reasons described therein.
> > All tests pass with Python 2.4, 2.5, 2.6, 2.7, 3.1, 3.2 on 64-bit
> > Ubuntu. The docs also appear to build. Before I re-based this I also
> > tested against Scipy, matplotlib, and pandas, and all were fine.
> While it's tempting to think that the lack of response to this
> email/PR indicates that everyone now agrees with me about how to
> proceed with the NA work, I'm for some reason unconvinced...
> Any objections to merging this?
No objection, but could you wait for this WE ? I am in the middle of
setting up a buildbot for windows for numpy (for both mingw and MSVC
compilers), and that would be a good way to test it.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the NumPy-Discussion