[Numpy-discussion] Scipy dot

Nicolas SCHEFFER scheffer.nicolas@gmail....
Mon Nov 12 19:39:55 CST 2012


Yep exactly.

I just want to make sure that we talked enough on the principle first
(ie. goals and technical approach), and that indeed the code is good
enough to look at.

I get it from your answer that it is, so I went ahead
https://github.com/numpy/numpy/pull/2730

Thanks

-nicolas

On Mon, Nov 12, 2012 at 12:59 PM, Nathaniel Smith <njs@pobox.com> wrote:
> On Mon, Nov 12, 2012 at 9:08 PM, Nicolas SCHEFFER
> <scheffer.nicolas@gmail.com> wrote:
>> I've pushed my code to a branch here
>> https://github.com/leschef/numpy/tree/faster_dot
>> with the commit
>> https://github.com/leschef/numpy/commit/ea037770e03f23aca1a06274a1a8e8bf0e0e2ee4
>>
>> Let me know if that's enough to create a pull request.
>
> "Pull request" basically means "this code is good enough to look at"
> -- the name is a bit misleading. It just creates a discussion thread
> where it's easy to look at the change, comment on pieces, etc., and
> you can continue to update the code after you start the pull request.
>
> -n
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion@scipy.org
> http://mail.scipy.org/mailman/listinfo/numpy-discussion


More information about the NumPy-Discussion mailing list