[Numpy-discussion] Change in behavior of np.concatenate for upcoming release

Matthew Brett matthew.brett@gmail....
Sat Sep 15 06:44:09 CDT 2012


Hi,

On Fri, Sep 14, 2012 at 11:25 PM, Han Genuit <hangenuit@gmail.com> wrote:
> I think there is something wrong with the implementation.. I would
> expect each incoming array in PyArray_ConcatenateFlattenedArrays to be
> flattened and the sizes of all of them added into a one-dimensional
> shape. Now the shape is two-dimensional, which does not make sense to
> me. Also the requirement that all sizes must be equal between the
> incoming arrays only makes sense when you want to stack them into a
> two-dimensional array, which makes it unnecessarily complicated. The
> difficulty here is to use PyArray_CopyAsFlat without having to
> transform/copy each incoming array to the priority dtype, because they
> can have different item sizes between them, but other than that it
> should be pretty straightforward, imo.
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion@scipy.org
> http://mail.scipy.org/mailman/listinfo/numpy-discussion

Thanks for the feedback. Feeling inadequate to a full understanding of
the code there, I've entered an issue for it:

https://github.com/numpy/numpy/issues/442

Ondrej - would you consider this a blocker for release?

Best,

Matthew


More information about the NumPy-Discussion mailing list