[Numpy-discussion] Nanmean review

Ralf Gommers ralf.gommers@gmail....
Sat Aug 10 02:21:11 CDT 2013


On Sat, Aug 10, 2013 at 12:48 AM, David Reed <david.reed.c@gmail.com> wrote:

>
> Hello,
>
> This is my first time contributing and I was hoping to get a review of a
> change I made.  Here is the comparison link.
>
> https://github.com/dvreed77/numpy/compare/nanmean
>

Hi David, your contribution looks good and adding nanmean is a good idea.
However, your code happens to overlap for almost 100% with an already
submitted pull request: https://github.com/numpy/numpy/pull/3534. I suggest
that you compare your implementation with the one in PR-3534, and maybe you
can add an example there or fix some inconsistency.

This doesn't seem all that consistent by the way. The PR doesn't have an
example, so I don't know if it behaves the same:

    >>> np.nanmean([1, np.nan, np.inf])       inf
>>> np.nanmean([1, np.nan, np.inf, np.NINF])       nan
Cheers,
Ralf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/numpy-discussion/attachments/20130810/384dfa58/attachment.html 


More information about the NumPy-Discussion mailing list