[Numpy-svn] [numpy/numpy] 4df244: BUG: do not "own" the FID for GzipFile and file if...

GitHub noreply@github....
Fri Jul 6 16:01:57 CDT 2012


  Branch: refs/heads/master
  Home:   https://github.com/numpy/numpy
  Commit: 4df244465c3db3a8e9e624d17ed2982f595e2b8a
      https://github.com/numpy/numpy/commit/4df244465c3db3a8e9e624d17ed2982f595e2b8a
  Author: Yaroslav Halchenko <debian@onerussian.com>
  Date:   2012-07-02 (Mon, 02 Jul 2012)

  Changed paths:
    M numpy/lib/npyio.py

  Log Message:
  -----------
  BUG: do not "own" the FID for GzipFile and file if provided to load already opened (ticket #2178)

Also made all assignments of own_file go in pair with assignments to fid to make things clearer


  Commit: 0e3a3d96c7a8e522184c7ca0388cd9d401e902cd
      https://github.com/numpy/numpy/commit/0e3a3d96c7a8e522184c7ca0388cd9d401e902cd
  Author: Yaroslav Halchenko <debian@onerussian.com>
  Date:   2012-07-02 (Mon, 02 Jul 2012)

  Changed paths:
    M numpy/lib/tests/test_io.py

  Log Message:
  -----------
  ENH: unittest for preceeding commit fixing #2178


  Commit: 4219824f899d31a0fb205536bf1477d68bcc5d71
      https://github.com/numpy/numpy/commit/4219824f899d31a0fb205536bf1477d68bcc5d71
  Author: Yaroslav Halchenko <debian@onerussian.com>
  Date:   2012-07-02 (Mon, 02 Jul 2012)

  Changed paths:
    M numpy/lib/npyio.py

  Log Message:
  -----------
  BF: PY3 and PY2 < 2.7 compatibility fixes for prev 2 commits


  Commit: 153f764db0a8bb15d52c76be44058922916abef5
      https://github.com/numpy/numpy/commit/153f764db0a8bb15d52c76be44058922916abef5
  Author: Yaroslav Halchenko <debian@onerussian.com>
  Date:   2012-07-05 (Thu, 05 Jul 2012)

  Changed paths:
    M numpy/lib/npyio.py

  Log Message:
  -----------
  ENH: Since file handle could not be reopened (during load()) -- no need for "isclosed" logic


  Commit: 81a03cff05e250fd9982042c332bd4e15e0b3962
      https://github.com/numpy/numpy/commit/81a03cff05e250fd9982042c332bd4e15e0b3962
  Author: Yaroslav Halchenko <debian@onerussian.com>
  Date:   2012-07-05 (Thu, 05 Jul 2012)

  Changed paths:
    M numpy/lib/tests/test_io.py

  Log Message:
  -----------
  ENH: added a rudimentary test for having #1517 (too many open files) fixed


  Commit: c35c83c2e7b9f0cd51606d5a63c36cc68cf4556a
      https://github.com/numpy/numpy/commit/c35c83c2e7b9f0cd51606d5a63c36cc68cf4556a
  Author: Yaroslav Halchenko <debian@onerussian.com>
  Date:   2012-07-05 (Thu, 05 Jul 2012)

  Changed paths:
    M numpy/lib/npyio.py

  Log Message:
  -----------
  BF: removed too much -- own_fid should be False while working with .npz


  Commit: 613589e2286b03171829bf4ff8cb5c9c863df4be
      https://github.com/numpy/numpy/commit/613589e2286b03171829bf4ff8cb5c9c863df4be
  Author: Yaroslav Halchenko <debian@onerussian.com>
  Date:   2012-07-06 (Fri, 06 Jul 2012)

  Changed paths:
    M numpy/lib/tests/test_io.py

  Log Message:
  -----------
  BF(PY3): open file handles in tests in binary mode

otherwise zipfile of python3 gets confused to receive bytes for the header
whenever handle is opened for a text (unicode) file


  Commit: 3b9a0fea12ae89fe6ce745d9af0beb3df17260b8
      https://github.com/numpy/numpy/commit/3b9a0fea12ae89fe6ce745d9af0beb3df17260b8
  Author: njsmith <njs@pobox.com>
  Date:   2012-07-06 (Fri, 06 Jul 2012)

  Changed paths:
    M numpy/lib/npyio.py
    M numpy/lib/tests/test_io.py

  Log Message:
  -----------
  Merge pull request #328 from yarikoptic/master

fix ticket #2178: "own" (to close) file handles in load() only if they were not opened before


Compare: https://github.com/numpy/numpy/compare/dd86cb378fb2...3b9a0fea12ae


More information about the Numpy-svn mailing list