[Numpy-svn] [numpy/numpy] ff0155: BUG: fix issue with distutils.exec_command introdu...

GitHub noreply@github....
Sun Mar 24 11:45:32 CDT 2013


  Branch: refs/heads/master
  Home:   https://github.com/numpy/numpy
  Commit: ff01555976cbbac5cb1ee9ecabc170a9d6886641
      https://github.com/numpy/numpy/commit/ff01555976cbbac5cb1ee9ecabc170a9d6886641
  Author: Ralf Gommers <ralf.gommers@googlemail.com>
  Date:   2013-03-06 (Wed, 06 Mar 2013)

  Changed paths:
    M numpy/distutils/exec_command.py
    A numpy/distutils/tests/test_exec_command.py

  Log Message:
  -----------
  BUG: fix issue with distutils.exec_command introduced in 1.7.0.

Closes gh-2999 and gh-2915.

There are several packages (nose, scipy.weave.inline, Sage inline Fortran) that
replace stdout, in which case it doesn't have a fileno method.  This method was
attempted to be used (change in gh-2766 to fix a py3k issue).


  Commit: 7c3b6dd33ec8bee517f1333e1dd0d4fb7078d01c
      https://github.com/numpy/numpy/commit/7c3b6dd33ec8bee517f1333e1dd0d4fb7078d01c
  Author: Ondrej Certik <ondrej.certik@gmail.com>
  Date:   2013-03-07 (Thu, 07 Mar 2013)

  Changed paths:
    M numpy/distutils/exec_command.py

  Log Message:
  -----------
  FIX: add _supports_fileno() for testing fileno()

The new _supports_fileno() function works in all versions of Python.
The problem was that in Python 2.x, the fileno() method of StringIO() is
missing, while in Python 3.x, it is present, but raises an exception.


  Commit: 6c6194a42cd0b5f47cfa7d43d7ae71c6b5e5ae84
      https://github.com/numpy/numpy/commit/6c6194a42cd0b5f47cfa7d43d7ae71c6b5e5ae84
  Author: Ondrej Certik <ondrej.certik@gmail.com>
  Date:   2013-03-07 (Thu, 07 Mar 2013)

  Changed paths:
    M numpy/distutils/exec_command.py

  Log Message:
  -----------
  PEP8: don't use \


  Commit: 2fbdd9903fc9bf6e1fe797e92c0157abd67850ce
      https://github.com/numpy/numpy/commit/2fbdd9903fc9bf6e1fe797e92c0157abd67850ce
  Author: Ondrej Certik <ondrej.certik@gmail.com>
  Date:   2013-03-09 (Sat, 09 Mar 2013)

  Changed paths:
    M numpy/distutils/tests/test_exec_command.py

  Log Message:
  -----------
  TST: add robust tests for exec_command()

First, we test both stdout and stderr.

Second, we now test both _exec_command_posix() and _exec_command(), see
numpy/distutils/exec_command.py. This reveals a bug in the implementation which
will be fixed in the next commit. For now the failing test is commented out so
that all tests still pass.


  Commit: 92770f4c6d6b74ee8788e621b67e757c1a21138e
      https://github.com/numpy/numpy/commit/92770f4c6d6b74ee8788e621b67e757c1a21138e
  Author: Ondrej Certik <ondrej.certik@gmail.com>
  Date:   2013-03-09 (Sat, 09 Mar 2013)

  Changed paths:
    M numpy/distutils/exec_command.py
    M numpy/distutils/tests/test_exec_command.py

  Log Message:
  -----------
  Implement separate checking for stdout and stderr

And enable a test for this that was failing before.


  Commit: 36c43214d25101c7acd63e0394877b5e04661639
      https://github.com/numpy/numpy/commit/36c43214d25101c7acd63e0394877b5e04661639
  Author: Ondrej Certik <ondrej.certik@gmail.com>
  Date:   2013-03-10 (Sun, 10 Mar 2013)

  Changed paths:
    M numpy/distutils/tests/test_exec_command.py

  Log Message:
  -----------
  TST: Redirect the other stream to temp. file

Now things behave the same if executed with either of:

nosetests
nosetests -s


  Commit: 5099683c351929e938985fd770b0a03cf7285ecb
      https://github.com/numpy/numpy/commit/5099683c351929e938985fd770b0a03cf7285ecb
  Author: Ondrej Certik <ondrej.certik@gmail.com>
  Date:   2013-03-10 (Sun, 10 Mar 2013)

  Changed paths:
    M numpy/distutils/tests/test_exec_command.py

  Log Message:
  -----------
  TST: skip general test on non-posix platforms

Add a comment explaining the issue.


  Commit: c96c69bf2c133c9c68480e3cb532693fb942c051
      https://github.com/numpy/numpy/commit/c96c69bf2c133c9c68480e3cb532693fb942c051
  Author: Ondřej Čertík <ondrej.certik@gmail.com>
  Date:   2013-03-24 (Sun, 24 Mar 2013)

  Changed paths:
    M numpy/distutils/exec_command.py
    A numpy/distutils/tests/test_exec_command.py

  Log Message:
  -----------
  Merge pull request #3128 from certik/pull-request-3127

BUG: fix issue with distutils.exec_command introduced in 1.7.0.


Compare: https://github.com/numpy/numpy/compare/bd7104cef45b...c96c69bf2c13


More information about the Numpy-svn mailing list