[Numpy-svn] [numpy/numpy] 623108: BUG: fix issue with distutils.exec_command introdu...

GitHub noreply@github....
Sun Mar 24 11:46:46 CDT 2013


  Branch: refs/heads/maintenance/1.7.x
  Home:   https://github.com/numpy/numpy
  Commit: 6231088d8cab49b657e9d713d48a932a3d0499f3
      https://github.com/numpy/numpy/commit/6231088d8cab49b657e9d713d48a932a3d0499f3
  Author: Ralf Gommers <ralf.gommers@googlemail.com>
  Date:   2013-03-10 (Sun, 10 Mar 2013)

  Changed paths:
    M numpy/distutils/exec_command.py
    A numpy/distutils/tests/test_exec_command.py

  Log Message:
  -----------
  BUG: fix issue with distutils.exec_command introduced in 1.7.0.

Closes gh-2999 and gh-2915.

There are several packages (nose, scipy.weave.inline, Sage inline Fortran) that
replace stdout, in which case it doesn't have a fileno method.  This method was
attempted to be used (change in gh-2766 to fix a py3k issue).

Conflicts:
	numpy/distutils/exec_command.py


  Commit: 1c016fbad21209e60693e68ab5e2c0a254f54f98
      https://github.com/numpy/numpy/commit/1c016fbad21209e60693e68ab5e2c0a254f54f98
  Author: Ondrej Certik <ondrej.certik@gmail.com>
  Date:   2013-03-10 (Sun, 10 Mar 2013)

  Changed paths:
    M numpy/distutils/exec_command.py

  Log Message:
  -----------
  FIX: add _supports_fileno() for testing fileno()

The new _supports_fileno() function works in all versions of Python.
The problem was that in Python 2.x, the fileno() method of StringIO() is
missing, while in Python 3.x, it is present, but raises an exception.


  Commit: 361a76c8c033925f0b4ae0c2231d4c0548772af2
      https://github.com/numpy/numpy/commit/361a76c8c033925f0b4ae0c2231d4c0548772af2
  Author: Ondrej Certik <ondrej.certik@gmail.com>
  Date:   2013-03-10 (Sun, 10 Mar 2013)

  Changed paths:
    M numpy/distutils/exec_command.py

  Log Message:
  -----------
  PEP8: don't use \


  Commit: 0ad86c5a112cf0d2e52a6f0f2ac61452f45d0e25
      https://github.com/numpy/numpy/commit/0ad86c5a112cf0d2e52a6f0f2ac61452f45d0e25
  Author: Ondrej Certik <ondrej.certik@gmail.com>
  Date:   2013-03-10 (Sun, 10 Mar 2013)

  Changed paths:
    M numpy/distutils/tests/test_exec_command.py

  Log Message:
  -----------
  TST: add robust tests for exec_command()

First, we test both stdout and stderr.

Second, we now test both _exec_command_posix() and _exec_command(), see
numpy/distutils/exec_command.py. This reveals a bug in the implementation which
will be fixed in the next commit. For now the failing test is commented out so
that all tests still pass.


  Commit: 8ca9bd5b5dc2ef9520bd3081c4c73bdc8d3b76e4
      https://github.com/numpy/numpy/commit/8ca9bd5b5dc2ef9520bd3081c4c73bdc8d3b76e4
  Author: Ondrej Certik <ondrej.certik@gmail.com>
  Date:   2013-03-10 (Sun, 10 Mar 2013)

  Changed paths:
    M numpy/distutils/exec_command.py
    M numpy/distutils/tests/test_exec_command.py

  Log Message:
  -----------
  Implement separate checking for stdout and stderr

And enable a test for this that was failing before.


  Commit: eb0e3f82cc70531359da2e0c7b5fa43a9103c26f
      https://github.com/numpy/numpy/commit/eb0e3f82cc70531359da2e0c7b5fa43a9103c26f
  Author: Ondrej Certik <ondrej.certik@gmail.com>
  Date:   2013-03-10 (Sun, 10 Mar 2013)

  Changed paths:
    M numpy/distutils/tests/test_exec_command.py

  Log Message:
  -----------
  TST: Redirect the other stream to temp. file

Now things behave the same if executed with either of:

nosetests
nosetests -s


  Commit: 1660575c3d61b3cbd5986cdf008d5d9c2e44de33
      https://github.com/numpy/numpy/commit/1660575c3d61b3cbd5986cdf008d5d9c2e44de33
  Author: Ondrej Certik <ondrej.certik@gmail.com>
  Date:   2013-03-10 (Sun, 10 Mar 2013)

  Changed paths:
    M numpy/distutils/tests/test_exec_command.py

  Log Message:
  -----------
  TST: skip general test on non-posix platforms

Add a comment explaining the issue.


  Commit: e1518439020db0ca73bc97ae8f22571337c0d59e
      https://github.com/numpy/numpy/commit/e1518439020db0ca73bc97ae8f22571337c0d59e
  Author: Ondrej Certik <ondrej.certik@gmail.com>
  Date:   2013-03-10 (Sun, 10 Mar 2013)

  Changed paths:
    M numpy/distutils/tests/test_exec_command.py

  Log Message:
  -----------
  TST: rework tests to work with Python 2.4

Instead of using the "with" statement, we introduce 'fake_with' function that
does the same.


  Commit: 9c5f31717f2e0698aece9aa2211f0ee79c18fdcd
      https://github.com/numpy/numpy/commit/9c5f31717f2e0698aece9aa2211f0ee79c18fdcd
  Author: Ondřej Čertík <ondrej.certik@gmail.com>
  Date:   2013-03-24 (Sun, 24 Mar 2013)

  Changed paths:
    M numpy/distutils/exec_command.py
    A numpy/distutils/tests/test_exec_command.py

  Log Message:
  -----------
  Merge pull request #3136 from certik/backport3128

Backport #3128


Compare: https://github.com/numpy/numpy/compare/16de6883fe16...9c5f31717f2e


More information about the Numpy-svn mailing list