[Numpy-tickets] [NumPy] #425: Faster clip for scalar clipping values
NumPy
numpy-tickets@scipy....
Thu Mar 29 14:48:25 CDT 2007
#425: Faster clip for scalar clipping values
------------------------------+---------------------------------------------
Reporter: david cournapeau | Owner: oliphant
Type: enhancement | Status: assigned
Priority: normal | Milestone:
Component: Other | Version: devel
Severity: normal | Resolution:
Keywords: |
------------------------------+---------------------------------------------
Changes (by oliphant):
* status: new => assigned
* owner: somebody => oliphant
Comment:
The next patch looks better. However, I still have several issues.
1) I see no need for two fastclip functions. The in-place function is
identical with calling the general one passing the in pointer to the out
position.
2) You should not add the fastclip.c file. Place the code in
multiarraymodule.c.
3) Don't introduce a new C-API function. Just replace PyArray_Clip
4) Your MANGLE macros in fastclip.c are hard to follow. Please simplify
these.
5) Thank you for your work. This does look like a nice addition.
--
Ticket URL: <http://projects.scipy.org/scipy/numpy/ticket/425#comment:7>
NumPy <http://projects.scipy.org/scipy/numpy>
The fundamental package needed for scientific computing with Python.
More information about the Numpy-tickets
mailing list