[Numpy-tickets] [NumPy] #599: Possible error in fromnumeric.py:_wrapit for nonarray types

NumPy numpy-tickets@scipy....
Wed Oct 24 17:17:14 CDT 2007


#599: Possible error in fromnumeric.py:_wrapit for nonarray types
------------------------+---------------------------------------------------
 Reporter:  dharland    |       Owner:  somebody
     Type:  defect      |      Status:  new     
 Priority:  normal      |   Milestone:          
Component:  numpy.core  |     Version:  none    
 Severity:  normal      |    Keywords:          
------------------------+---------------------------------------------------
 By chance I noticed this odd looking snippet of code in _wrapit.

 {{{
     if wrap and isinstance(result, mu.ndarray):
         if not isinstance(result, mu.ndarray):  # - SURELY THIS CAN NEVER
 BE TRUE?!
             result = asarray(result)
         result = wrap(result)
 }}}

 Should this instead be?

 {{{
     if wrap:
         if not isinstance(result, mu.ndarray):
             result = asarray(result)
         result = wrap(result)
 }}}

-- 
Ticket URL: <http://scipy.org/scipy/numpy/ticket/599>
NumPy <http://projects.scipy.org/scipy/numpy>
The fundamental package needed for scientific computing with Python.


More information about the Numpy-tickets mailing list