[NumPy-Tickets] [NumPy] #1625: Numpy is ignoring the fact "isfinite" is undefined

[NumPy Trac]

#1625: Numpy is ignoring the fact "isfinite" is undefined
----------------------+-----------------------------------------------------
 Reporter:  drkirkby  |       Owner:  somebody
     Type:  defect    |      Status:  new     
 Priority:  normal    |   Milestone:  2.0.0   
Component:  Other     |     Version:  1.5.0   
 Keywords:            |  
----------------------+-----------------------------------------------------

Comment(by charris):

 ''This seems to be the case in point here.''

 I don't think so. I suspect it is this bit of code in
 numpy/distutils/command/config.py


 {{{
 int main()
 {
 #ifndef %s
     (void) %s;
 #endif
     ;
     return 0;
 }""" % (symbol, symbol)

 }}}

 which only looks to see if the macro is defined, not whether it is true of
 false. I suspect we need to make the compilation fail if the symbol is
 defined to 0. Maybe changing it to

 {{{
 int main()
 {
 #ifndef %s
     (void) %s;
 #elif %s == 0
 #error
 #endif
     ;
     return 0;
 }""" % (symbol, symbol, symbol)

 }}}

 will do the trick. The numpy build process is pretty complicated so it
 would be nice if David Cournapeau could take a look at this.

-- 
Ticket URL: <http://projects.scipy.org/numpy/ticket/1625#comment:5>
NumPy <http://projects.scipy.org/numpy>
My example project