[NumPy-Tickets] [NumPy] #2136: PyArray_Diagonal view transition for 1.8

[NumPy Trac]

#2136: PyArray_Diagonal view transition for 1.8
--------------------+-------------------------------------------------------
 Reporter:  njs     |       Owner:  somebody
     Type:  defect  |      Status:  new     
 Priority:  normal  |   Milestone:  1.8.0   
Component:  Other   |     Version:  1.6.1   
 Keywords:          |  
--------------------+-------------------------------------------------------

Old description:

> Starting in 1.8, PyArray_Diagonal is supposed to start returning a non-
> writeable view.
>
> To do:
>
> * Make the (trivial) change at the bottom of PyArray_Diagonal
> * Update the numpy.diagonal documentation
> * Make a note in the release notes
> * Optionally, remove NPY_ARRAY_WARN_ON_WRITE flag. If so, see the below
> pull request to find the code to change. Even if we decide to keep it
> around for a rainy day, the message in array_might_be_written should have
> the references to diagonals removed.
>
> Reference: https://github.com/numpy/numpy/pull/280

New description:

 Starting in 1.8, PyArray_Diagonal is supposed to start returning a non-
 writeable view.

 To do:

   * Make the (trivial) change at the bottom of PyArray_Diagonal
   * Update the numpy.diagonal documentation
   * Make a note in the release notes
   * Optionally, remove NPY_ARRAY_WARN_ON_WRITE flag. If so, see the
   below pull request to find the code to change. Even if we decide
   to keep it around for a rainy day, the message in
   array_might_be_written should have the references to diagonals
   removed.

 Reference: https://github.com/numpy/numpy/pull/280

--

Comment(by rgommers):

 <reformat description>

-- 
Ticket URL: <http://projects.scipy.org/numpy/ticket/2136#comment:1>
NumPy <http://projects.scipy.org/numpy>
My example project