[SciPy-dev] Bug in weave, current SVN.

[Jarrod Millman]

Whoops, my bad.  I will fix this later today.
Sorry,
Jarrod

On Nov 13, 2007 12:28 PM, Fernando Perez <fperez.net@gmail.com> wrote:
> Hi all,
>
> a bug recently popped up in weave, I was wondering if anyone would
> mind the fix attached.  I can commit it, but since I don't regularly
> touch the codebase, I prefer to check for approval from the regulars.
>
> The problem was lines like:
>
> code = arg_strings.join("")
>
> which are backwards: join() must be used as string.join(list), not
> list.join(string).  In addition, I added minimal docstrings and
> rewrote the three little offending routines as list comprehensions,
> which are faster and (to me) more readable.  I can also just commit
> the bare fix without any 'improvements' if there are objections.
>
> Thanks!
>
> f
>
> _______________________________________________
> Scipy-dev mailing list
> Scipy-dev@scipy.org
> http://projects.scipy.org/mailman/listinfo/scipy-dev
>
>



-- 
Jarrod Millman
Computational Infrastructure for Research Labs
10 Giannini Hall, UC Berkeley
phone: 510.643.4014
http://cirl.berkeley.edu/