[SciPy-dev] Two new test failures

Christopher Hanley chanley@stsci....
Thu Nov 13 09:39:36 CST 2008


josef.pktd@gmail.com wrote:
> On Thu, Nov 13, 2008 at 9:53 AM, Christopher Hanley <chanley@stsci.edu> wrote:
>> Hi,
>>
>> I am getting two new test failures from scipy.  They appear to be from
>> some test tests added yesterday in the stats package.
>>
>> ======================================================================
>> FAIL: test_discrete_chisquare.test_discrete_rvs_cdf('logser',
>> (0.59999999999999998,))
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>>   File "/Users/chanley/dev/site-packages/lib/python/nose/case.py", line
>> 182, in runTest
>>     self.test(*self.arg)
>>   File
>> "/Users/chanley/dev/site-packages/lib/python/scipy/stats/tests/test_discrete_chisquare.py",
>> line 77, in check_discrete_chisquare
>>     'at arg = %s' % (distname,str(arg))
>> AssertionError: chisquare - test for logserat arg = (0.59999999999999998,)
>>
>> ======================================================================
>> FAIL: test_discrete_chisquare.test_discrete_rvs_cdf('nbinom', (5, 0.5))
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>>   File "/Users/chanley/dev/site-packages/lib/python/nose/case.py", line
>> 182, in runTest
>>     self.test(*self.arg)
>>   File
>> "/Users/chanley/dev/site-packages/lib/python/scipy/stats/tests/test_discrete_chisquare.py",
>> line 77, in check_discrete_chisquare
>>     'at arg = %s' % (distname,str(arg))
>> AssertionError: chisquare - test for nbinomat arg = (5, 0.5)
>>
>> ----------------------------------------------------------------------
>> Ran 3161 tests in 172.342s
>>
>> FAILED (SKIP=28, failures=2)
>> <nose.result.TextTestResult run=3161 errors=0 failures=2>
>>
>> I am running OSX 10.5 on an Intel Mac.  I have svn versions of both
>> numpy and scipy:
>>
>>  >>> scipy.__version__
>> '0.7.0.dev5090'
>>  >>> numpy.__version__
>> '1.3.0.dev6022'
>>
>> Chris
>>
>> --
>> Christopher Hanley
>> Senior Systems Software Engineer
>> Space Telescope Science Institute
>> 3700 San Martin Drive
>> Baltimore MD, 21218
>> (410) 338-4338
>> _______________________________________________
>> Scipy-dev mailing list
>> Scipy-dev@scipy.org
>> http://projects.scipy.org/mailman/listinfo/scipy-dev
>>
> 
> Thanks for testing.
> 
> The first test failure in logser is a known failure that I haven't
> marked yet as such (the error is in numpy.random according to my
> tests). The second failure, nbinom, I don't get in my test runs. Since
> these are random tests, it might be an accidental failure and I might
> have to add a comment or reduce the precision of the test. Could you
> run the tests again, just scipy.stats, to see if the second test fails
> each time or just accidentally? I will also check again, that there
> are no problems left with nbinom.
> 
> By the way, these are failures because of new tests with more coverage
> and not because of new bugs.
> 
> Josef
> _______________________________________________
> Scipy-dev mailing list
> Scipy-dev@scipy.org
> http://projects.scipy.org/mailman/listinfo/scipy-dev

The nbinom test does fail randomly. Although for me it seems to fail 
more times than it passes. Reducing the precision of the test would 
probably be a good idea.

Thank you for taking the time to expand the test coverage in scipy.  The 
effort is appreciated.

Chris


-- 
Christopher Hanley
Senior Systems Software Engineer
Space Telescope Science Institute
3700 San Martin Drive
Baltimore MD, 21218
(410) 338-4338


More information about the Scipy-dev mailing list