[SciPy-dev] Should ndimage.measurements.* should return lists if index is a list?
Sat Apr 18 19:16:43 CDT 2009
I'm looking over the patch currently, but let me ask a quick question
first: is there a performance (or other) reason to not just do the
list-wrapping/unwrapping thing in Python, rather than in the C code?
On Apr 18, 2009, at 7:28 PM, Thouis (Ray) Jones wrote:
> My last patch did not do the right thing for ndimage.extrema(), which
> needs to return 4 values with the same semantics. I've attached an
> Ray Jones
> On Sat, Apr 18, 2009 at 16:47, Thouis (Ray) Jones <firstname.lastname@example.org
> > wrote:
>> Here's a first attempt at a patch. It fixes the corner case of a
>> single index to match the index type (scalar for scalar, list for
>> single element sequence), also the case of index= to return  for
>> any measurement. Finally, it improves type checking of the index
>> type, which was only being checked for sum() and not any of the other
>> measurements (?).
>> Zach, would you mind reviewing? If it looks good, I'll add some
>> for the new functionality and submit a patch via trac.
>> On Fri, Apr 17, 2009 at 22:06, Zachary Pincus <email@example.com
>> > wrote:
>>>> Current behavior:
>>>>>>> from scipy import ndimage
>>>>>>> ndimage.maximum([[1,2], [3,4]], [[1,0],[0,2]], index=[1,2])
>>>> [1.0, 4.0]
>>>>>>> ndimage.maximum([[1,2], [3,4]], [[1,0],[0,2]], index=)
>>>>>>> ndimage.maximum([[1,2], [3,4]], [[1,0],[0,2]], index=1)
>>>> I think the second result should be [1.0]. We're using the ndimage
>>>> code for image processing, and have to wrap the measurement
>>>> to make the code general for the case where there is only one
>>>> in the image.
>>> I've run into this too, and had the same thought. It's such a
>>> case that it doesn't seem like gratuitous API-breakage to make this
>>> Scipy-dev mailing list
> Scipy-dev mailing list
More information about the Scipy-dev