[SciPy-dev] Scipy workflow (and not tools).

Stéfan van der Walt stefan@sun.ac...
Wed Feb 25 13:45:21 CST 2009


Hi Travis

2009/2/25 Travis E. Oliphant <oliphant@enthought.com>:
> Which code has no tests?   Are you speaking rhetorically or about a
> specific check-in?

I don't want to focus on any commits specifically (this kind of thing
happens across the board), but I'll give one example that involves
yourself.  Take a look at

http://projects.scipy.org/scipy/scipy/changeset/5554

You added a very useful function (thank you very much!).  I haven't
played with decimation filters recently, so I added a very naïve test:

http://projects.scipy.org/scipy/scipy/changeset/5560

Let's face it, you could have done a much better job there than I could.

Besides the neat function you added, you also fixed a spelling
mistake.  Unfortunately, "Filifilt" became "filtflit", which is also
incorrect.  Also, you accidentally changed "lfilter_zi" to
"lfiltir_zi".  I fixed that in:

http://projects.scipy.org/scipy/scipy/changeset/5557

Even a cursory review of the patch would have caught these issues.

I appreciate that you want SciPy to remain organic and free; a place
where motivated developers strive to grow the codebase to an
efficient, powerful computing machine.  I share that vision, although
I'd like us to turn the gears up a bit, oil the machine, and encourage
one another to write better code.

Regards
Stéfan


More information about the Scipy-dev mailing list