[SciPy-dev] Initial tests for optimize.fsolve()

Pauli Virtanen pav@iki...
Sun Mar 22 15:33:07 CDT 2009


Sun, 22 Mar 2009 21:26:42 +0200, Yosef Meller wrote:

> Added a test problem and two initial tests that just check that nothing
> croaks: a run without a jacobian and a run with a jacobian.
> 
> Now, I kind of lost track of the whole workflow discussion, so please
> tell me what process to follow to get this in.

In general: open a ticket, attach the patch (or, even better, post it to 
the codereview site and paste the URL to the ticket, or branch your own 
Git clone and paste an URL to it), finally marking the ticket as needs 
review.

And maybe, ping this mailing list, too.

Or, you can just send the patch to this mailing list, but then it's quite 
possible that it gets lost in the traffic and people forget about it. 
This one was a trivial change, so I just committed it directly (r5633).

> Also, is the huge docstring in TestFSolve.pressure_network() an
> overkill?

The docstring is ok, not too big, though maybe not indispensable.

-- 
Pauli Virtanen



More information about the Scipy-dev mailing list