[SciPy-dev] RFR: #902 firwin upgrades
Charles R Harris
Sun May 10 23:09:48 CDT 2009
On Sun, May 10, 2009 at 8:41 PM, Tom K. <email@example.com> wrote:
> (I sent this to firstname.lastname@example.org, thinking it would appear here,
> I am horribly confused - sorry for the duplication :-)
> SIMPLE REVIEW NEEDED - SINGLE FUNCTION
> Link to Trac ticket: http://projects.scipy.org/scipy/ticket/902
> This is adding a highpass, bandpass, bandstop, and multiband capability to
> signal.firwin. I submitted a patch attached to the ticket to
> I also added a test class in tests/test_filter_design.py.
> Let me know if there are any problems with the patch as this is my first
> to scipy and I am new to SVN.
I think class BandPass is too general a name for a method based on
windowing. Have you looked at the remez filter design? You can design the
type of filters you are talking about using it also.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Scipy-dev