[SciPy-Dev] linalg: cho_solve in basic.py and decomp.py

David Warde-Farley dwf@cs.toronto....
Wed Apr 21 22:12:23 CDT 2010


Warren Weckesser wrote:
> Warren Weckesser wrote:
>   
>> Warren Weckesser wrote:
>>   
>>     
>>>  I just noticed that the function cho_solve() is implemented in both 
>>> basic.py and decomp.py in the linalg package.  In __init__.py, decomp is 
>>> imported after basic, so its implementation is used.  Both are wrappers 
>>> of the lapack function potrs,  and they do almost exactly the same 
>>> thing, but the implementation in basic.py handles an additional boolean 
>>> keyword argument, 'overwrite_b'.
>>>
>>> Any objections if I merge the two into one implementation in basic.py 
>>> (where the solvers seem to live), and keep the extra keyword argument?
>>>
>>>   
>>>     
>>>       
>> Minor change to that suggestion--I'd update the version in decomp.py, 
>> and remove it from basic.py.
>>
>> Warren
>>
>>
>>   
>>     
>
> lu_solve() is also implemented in both modules, but in this case, 
> decomp.py doesn't include lu_solve in __all__.  Go figure.
>
> I'll clean up both modules, and, while I'm at it, incorporate the patch 
> that Yaroslav Halchenko recently reminded the list about
>   
I'm way behind on my mailing list mail but +1 ahoy.

David


More information about the SciPy-Dev mailing list