[SciPy-Dev] signal.freqs/freqz plot keyword

Ralf Gommers ralf.gommers@googlemail....
Sat Jul 17 04:38:17 CDT 2010


freqs/freqz have a keyword plot=None, which if True does this:
if not plot is None:
    plot(w, h)
while plot is not even defined. This keyword should be removed or the
implementation should be something like:
    if plot:
        try:
            import matplotlib.pyplot as plt
            plt.plot(w, h)
            plt.show()
        except ImportError:
            warnings.warn("`plot` is True, but can't import
matplotlib.pyplot.")

Removal makes more sense I think, since scipy does not depend on matplotlib.
And why provide a plot keyword in these functions and not in many others
where it would also make sense?

It's ticket http://projects.scipy.org/scipy/ticket/896

Cheers,
Ralf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.scipy.org/pipermail/scipy-dev/attachments/20100717/9b91b76c/attachment.html 


More information about the SciPy-Dev mailing list