[SciPy-Dev] Another easy patch review: ticket #996

Warren Weckesser warren.weckesser@enthought....
Sun Mar 21 16:13:31 CDT 2010


Robert Kern wrote:
> On Sun, Mar 21, 2010 at 15:51, Warren Weckesser
> <warren.weckesser@enthought.com> wrote:
>   
>> I added a patch to ticket #996 that implements the change discussed
>> there.  The change to the code is trivial; the main issue is that
>> everyone else agrees that the `find` function should return the list of
>> keys instead of printing them.  Personally I think it's another no-brainer.
>>     
>
> Requests for "no-brainer" reviews tend to go faster when they include
> a link to the ticket. :-)
>   

+1 on the suggestion--noted for future reference.

> Anyways, +1 on the patch.
>
>   

OK, in it goes.

Warren



More information about the SciPy-Dev mailing list